[PATCH] D18772: [lld] Implement --dynamic-list

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 5 13:53:07 PDT 2016


ruiu added inline comments.

================
Comment at: ELF/DynamicList.cpp:35
@@ +34,3 @@
+//  { symbol1; symbol2; extern "C++" { symbol3; namespace::symbol4 }; }
+//
+// With the ';' after symbol4 being optional.  Multiple groups can be
----------------
I don't want to support them until it is proved that we absolutely have to do that because it has huge performance impact if the option is enabled. The reason that "because gnu ld/gold do this" is too weak to justify. Even if it wouldn't hurt the default case, I wouldn't like to land a patch C++ name mangling and glob patterns right now, particularly as a part of the other large patch (I meant this patch which implements --dynamic-list.)


http://reviews.llvm.org/D18772





More information about the llvm-commits mailing list