[PATCH] D18471: [CodeGen] Don't assume that fixed stack objects are aligned in a stack-realigned function.

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 5 11:43:14 PDT 2016


rnk added a subscriber: rnk.
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm


================
Comment at: lib/CodeGen/MachineFunction.cpp:87-88
@@ -80,2 +86,4 @@
+      MachineFrameInfo(getFnStackAlignment(STI, Fn),
                        STI->getFrameLowering()->isStackRealignable(),
-                       !F->hasFnAttribute("no-realign-stack"));
+                       !F->hasFnAttribute("no-realign-stack"),
+                       !F->hasFnAttribute("no-realign-stack") &&
----------------
As a separate issue, I noticed that StackRealignable and RealignOpt are redundant. We can get by with just StackRealignable, and making that be `STI->getFrameLowering()->isStackRealignable() && F->hasFnAttribute("no-realign-stack")`.


http://reviews.llvm.org/D18471





More information about the llvm-commits mailing list