[PATCH] D18729: [llvm-c] Improve IR Introspection: Add ValueKind

[Amaury SECHET via llvm-commits]

deadalnix added inline comments.

================
Comment at: tools/llvm-c-test/echo.cpp:230-231
@@ +229,4 @@
+        report_fatal_error("Could not find function");
+      if (LLVMGetValueKind(Ret) != LLVMFunctionValueKind)
+        report_fatal_error("LLVMGetValueKind returned incorrect type");
+      return Ret;
----------------
Instead of reproducing this pattern of over the place, I think it would make sense to factor it out.

================
Comment at: tools/llvm-c-test/echo.cpp:297
@@ -296,3 +340,2 @@
 
-  // At this point, it must be a constant expression
   LLVMOpcode Op = LLVMGetConstOpcode(Cst);
----------------
Keep the comment please.


http://reviews.llvm.org/D18729