[PATCH] D18108: Swift Calling Convention: SelectionDAGBuilder changes to support swifterror

[Manman Ren via llvm-commits]

manmanren marked 3 inline comments as done.
manmanren added a comment.

Thanks for reviewing the patch!
Manman


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:5724
@@ +5723,3 @@
+      SwiftErrorVal = V;
+      // We find the virtual register for the actual swifterror argument.
+      // Instead of using the Value, we use the virtual register instead.
----------------
qcolombet wrote:
> Could you add a test case for that change?
Sure. I will upload a test case with the target-specific change (http://reviews.llvm.org/D18716).


http://reviews.llvm.org/D18108