[PATCH] D18778: [LLVM] Fix Clang-tidy modernize-deprecated-headers warnings in remaining files; other minor fixes

[Eugene Zelenko via llvm-commits]

Eugene.Zelenko added inline comments.

================
Comment at: lib/Support/CrashRecoveryContext.cpp:12
@@ -11,2 +11,3 @@
 #include "llvm/Config/config.h"
+#include "llvm/ADT/STLExtras.h"
 #include "llvm/Support/ErrorHandling.h"
----------------
aaron.ballman wrote:
> Can you sort these includes, or was this the ordering generated?
Will do in commit.

================
Comment at: lib/Support/SHA1.cpp:50
@@ -48,2 +49,3 @@
 
-static uint32_t rol32(uint32_t number, uint8_t bits) {
+namespace {
+
----------------
aaron.ballman wrote:
> I think that having a single static function definition is a bit more clear than having an anonymous namespace, but I don't feel that strongly about it. Thoughts?
I definitely saw single functions in anonymous namespace in LLVM code.


Repository:
  rL LLVM

http://reviews.llvm.org/D18778