[PATCH] D18394: [TableGen] AsmMatcherEmitter.cpp: replace a sequence of "if" to "switch" in emitValidateOperandClass. NFC.

Valery Pykhtin via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 5 09:23:47 PDT 2016


This revision was automatically updated to reflect the committed changes.
Closed by commit rL265412: [TableGen] AsmMatcherEmitter.cpp: replace a sequence of "if" to "switch" in… (authored by vpykhtin).

Changed prior to commit:
  http://reviews.llvm.org/D18394?vs=51415&id=52705#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D18394

Files:
  llvm/trunk/utils/TableGen/AsmMatcherEmitter.cpp

Index: llvm/trunk/utils/TableGen/AsmMatcherEmitter.cpp
===================================================================
--- llvm/trunk/utils/TableGen/AsmMatcherEmitter.cpp
+++ llvm/trunk/utils/TableGen/AsmMatcherEmitter.cpp
@@ -2153,19 +2153,23 @@
 
   // Check the user classes. We don't care what order since we're only
   // actually matching against one of them.
+  OS << "  switch (Kind) {\n"
+        "  default: break;\n";
   for (const auto &CI : Info.Classes) {
     if (!CI.isUserClass())
       continue;
 
     OS << "  // '" << CI.ClassName << "' class\n";
-    OS << "  if (Kind == " << CI.Name << ") {\n";
+    OS << "  case " << CI.Name << ":\n";
     OS << "    if (Operand." << CI.PredicateMethod << "())\n";
     OS << "      return MCTargetAsmParser::Match_Success;\n";
     if (!CI.DiagnosticType.empty())
       OS << "    return " << Info.Target.getName() << "AsmParser::Match_"
          << CI.DiagnosticType << ";\n";
-    OS << "  }\n\n";
+    else
+      OS << "    break;\n";
   }
+  OS << "  } // end switch (Kind)\n\n";
 
   // Check for register operands, including sub-classes.
   OS << "  if (Operand.isReg()) {\n";


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D18394.52705.patch
Type: text/x-patch
Size: 1152 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160405/6dcb171a/attachment.bin>


More information about the llvm-commits mailing list