[PATCH] D18773: [lld] Implement --dynamic-list-data

[Adhemerval Zanella via llvm-commits]

zatrazz added inline comments.

================
Comment at: test/ELF/dynamic-list-data.s:3
@@ +2,3 @@
+
+## This object is build in linked against to force dynamic loading without
+## the use of full paths in linking command.
----------------
rafael wrote:
> not sure I can parse "is build in liked"
Yeah the wording is fuzzy, I will change that.

================
Comment at: test/ELF/dynamic-list-data.s:6
@@ +5,3 @@
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %p/Inputs/shared.s -o %t2.o
+# RUN: ld.lld -shared %t2.o -soname shared -o %t2.so
+
----------------
rafael wrote:
> Why do you need the soname?
Just to force test to be dynamically linked without the need to pass either the libc or another system library.


Repository:
  rL LLVM

http://reviews.llvm.org/D18773