[PATCH] D18710: code hoisting using GVN

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 4 19:57:10 PDT 2016


chandlerc added a subscriber: chandlerc.
chandlerc added a comment.

Folks, you didn't follow the specific guidance about how to create a patch
with Phabricator. Specifically, when you created the revision, the
'llvm-commits' list was not CC'ed.

As a result, I suspect a large number of folks are getting inline comments
with *zero context* about what this patch even is. That includes myself. It
makes it super hard to even understand what is going on.

Please nuke this entry on Phab, and create a fresh one with the mailing
list attached. That way it will send a nice original email with the actual
patch file attached.

It would also be really nice if the summary were substantially more useful
than "code hoisting using GVN" which sounds like adding a feature to GVN.
The actual description in PHab seems *very* different:
"""
This pass hoists common computations across branches sharing common
immediate dominator. Like early-cse, the primary goal of early-gvn is to
reduce the size of functions before inline heuristics to reduce the total
cost of function inlining.
"""

So this is actually introducing a totally new pass?? Very confused. Waiting
for a fresh code review to make detailed comments.


http://reviews.llvm.org/D18710





More information about the llvm-commits mailing list