[PATCH] D18719: setUsedInRegulawrObj and MustBeInDynSym fixes

[Peter Collingbourne via llvm-commits]

pcc abandoned this revision.
pcc added a comment.

Obsoleted by http://reviews.llvm.org/D18780 and http://reviews.llvm.org/D18781.


================
Comment at: ELF/SymbolTable.cpp:102-103
@@ -101,1 +101,4 @@
   Lto.reset(new BitcodeCompiler);
+  for (auto &F : ObjectFiles)
+    for (auto S : F->getSymbols())
+      S->repl().setUsedInRegularObj();
----------------
ruiu wrote:
> Please use real types instead of `auto`.
This part is (I believe) redundant with Davide's r265208.

================
Comment at: ELF/Symbols.cpp:188
@@ -187,3 +187,3 @@
   if (isShared() != Other->isShared())
-    if (isa<DefinedRegular<ELFT>>(isShared() ? Other : this))
+    if (isa<Defined>(isShared() ? Other : this))
       MustBeInDynSym = Other->MustBeInDynSym = true;
----------------
ruiu wrote:
> Now we can make SymbolBody::compare non-template function? (You can do that in a follow-up patch.)
D18781


http://reviews.llvm.org/D18719