[PATCH] D18731: ELF: Create dynamic symbols for symbol aliases of copy relocations.

[Peter Collingbourne via llvm-commits]

pcc marked 2 inline comments as done.

================
Comment at: ELF/Writer.cpp:765
@@ +764,3 @@
+      SSInFile.MustBeInDynSym = true;
+      if (SSInFile.Sym.getBinding() == ELF::STB_GLOBAL)
+        CopyRelSS = &SSInFile;
----------------
rafael wrote:
> Why do you need this?
> 
> Can you leave it out and just pass SS to addReloc?
I observed that gold was creating a copy relocation to the strong symbol if the referenced symbol was weak. That's not a very good justification though, and nothing seems to break if I do as you suggest, so let's do that.


http://reviews.llvm.org/D18731