[PATCH] D18736: [llvm-c] Improve IR Introspection: Add LLVM{Get, Set}ModuleIdentifier

Nicole Mazzuca via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 4 15:27:14 PDT 2016


ubsan added inline comments.

================
Comment at: lib/IR/Core.cpp:167
@@ +166,3 @@
+void LLVMSetModuleIdentifier(LLVMModuleRef M, const char *Ident, size_t Len) {
+  unwrap(M)->setModuleIdentifier({Ident, Len});
+}
----------------
whitequark wrote:
> Actually, can you call `StringRef` constructor here? I'm pretty sure I've never seen brace-initializer style anywhere else in LLVM.
Yeah, I can. I will change it when I can.


http://reviews.llvm.org/D18736





More information about the llvm-commits mailing list