[PATCH] D18731: ELF: Create dynamic symbols for symbol aliases of copy relocations.

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: ELF/Writer.cpp:759-760
@@ +758,4 @@
+  // any aliases.
+  for (SharedSymbol<ELFT> &SSInFile : SS->File->getSharedSymbols()) {
+    if (SSInFile.Sym.st_shndx == Shndx && SSInFile.Sym.st_value == Value) {
+      SSInFile.OffsetInBss = Off;
----------------
Let's use a shorter name and early continue.

  for (SharedSymbol<ELFT> &S : SS->File->getSharedSymbols()) {
    if (S.Sym.st_shndx != Shndx || S.Sym.st_value != Value)
      continue;


http://reviews.llvm.org/D18731