[llvm] r265348 - Clean up calls to WriteBitcodeToFile (NFC)

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 4 14:19:32 PDT 2016


Author: tejohnson
Date: Mon Apr  4 16:19:31 2016
New Revision: 265348

URL: http://llvm.org/viewvc/llvm-project?rev=265348&view=rev
Log:
Clean up calls to WriteBitcodeToFile (NFC)

Remove a default parameter value being passed unnecessarily, which
also reduces the changes required when this parameter is changed in
D18763.

Document the remaining non-default bool value passed for another
parameter.

Modified:
    llvm/trunk/lib/LTO/ThinLTOCodeGenerator.cpp
    llvm/trunk/tools/llvm-lto/llvm-lto.cpp

Modified: llvm/trunk/lib/LTO/ThinLTOCodeGenerator.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/LTO/ThinLTOCodeGenerator.cpp?rev=265348&r1=265347&r2=265348&view=diff
==============================================================================
--- llvm/trunk/lib/LTO/ThinLTOCodeGenerator.cpp (original)
+++ llvm/trunk/lib/LTO/ThinLTOCodeGenerator.cpp Mon Apr  4 16:19:31 2016
@@ -91,7 +91,7 @@ static void saveTempBitcode(const Module
   if (EC)
     report_fatal_error(Twine("Failed to open ") + SaveTempPath +
                        " to save optimized bitcode\n");
-  WriteBitcodeToFile(&TheModule, OS, true, false);
+  WriteBitcodeToFile(&TheModule, OS, /* ShouldPreserveUseListOrder */ true);
 }
 
 bool IsFirstDefinitionForLinker(const GlobalValueInfoList &GVInfo,

Modified: llvm/trunk/tools/llvm-lto/llvm-lto.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-lto/llvm-lto.cpp?rev=265348&r1=265347&r2=265348&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-lto/llvm-lto.cpp (original)
+++ llvm/trunk/tools/llvm-lto/llvm-lto.cpp Mon Apr  4 16:19:31 2016
@@ -316,7 +316,7 @@ static void writeModuleToFile(Module &Th
   std::error_code EC;
   raw_fd_ostream OS(Filename, EC, sys::fs::OpenFlags::F_None);
   error(EC, "error opening the file '" + Filename + "'");
-  WriteBitcodeToFile(&TheModule, OS, true, false);
+  WriteBitcodeToFile(&TheModule, OS, /* ShouldPreserveUseListOrder */ true);
 }
 
 class ThinLTOProcessing {




More information about the llvm-commits mailing list