[PATCH] D18769: Swift Calling Convention: swiftcc implementation on ARM

[Manman Ren via llvm-commits]

manmanren added a comment.

In http://reviews.llvm.org/D17863#371104, @t.p.northover wrote:

> Hi Manman,
>
> I think the testing is too weak if we're going for ABI stability (particularly based on FastCC, which is explicitly called out in the LangRef as unstable and based on APCS). I'd actually strongly suggest Swift starts out with AAPCS_VFP on ARM.


This is now updated to use AAPCS_VFP.

> Even with that, I'd suggest testing things like minimum stack slot size, alignment of objects on the stack, whether everything goes on the stack if something has. Probably on both iOS and WatchOS because I suspect those details differ based on type alignment.


Do the testings for WatchOS already exist? If yes, can you point me which file so it will be easier for me to add coverage for iOS?
For Swift on WatchOS, we are using the same convention as C/C++, so I don't quite get what extra testings we would like to include for Swift.

Thanks,
Manman


http://reviews.llvm.org/D18769