[lld] r265310 - [ELF][MIPS] Extend test case to check LA25 stubs creation for STO_MIPS_PIC symbols. NFC.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 4 12:16:41 PDT 2016


Thanks!

On 4 April 2016 at 12:47, Simon Atanasyan via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: atanasyan
> Date: Mon Apr  4 11:47:31 2016
> New Revision: 265310
>
> URL: http://llvm.org/viewvc/llvm-project?rev=265310&view=rev
> Log:
> [ELF][MIPS] Extend test case to check LA25 stubs creation for STO_MIPS_PIC symbols. NFC.
>
> The only way to get an object file with symbols marked by the STO_MIPS_PIC
> flag is to link PIC and non-PIC object files and generate a relocatable
> output using '-r' command line option. Now LLD is able to generate a relocatable
> output but does not mark PIC symbols by the STO_MIPS_PIC flag. So I have
> to use binary input mips-sto-pic.o generated by GNU BFD linker.
>
> Added:
>     lld/trunk/test/ELF/Inputs/mips-sto-pic.o
> Modified:
>     lld/trunk/test/ELF/mips-npic-call-pic.s
>
> Added: lld/trunk/test/ELF/Inputs/mips-sto-pic.o
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/Inputs/mips-sto-pic.o?rev=265310&view=auto
> ==============================================================================
> Binary files lld/trunk/test/ELF/Inputs/mips-sto-pic.o (added) and lld/trunk/test/ELF/Inputs/mips-sto-pic.o Mon Apr  4 11:47:31 2016 differ
>
> Modified: lld/trunk/test/ELF/mips-npic-call-pic.s
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/mips-npic-call-pic.s?rev=265310&r1=265309&r2=265310&view=diff
> ==============================================================================
> --- lld/trunk/test/ELF/mips-npic-call-pic.s (original)
> +++ lld/trunk/test/ELF/mips-npic-call-pic.s Mon Apr  4 11:47:31 2016
> @@ -4,50 +4,73 @@
>  # RUN: llvm-mc -filetype=obj -triple=mips-unknown-linux \
>  # RUN:   %p/Inputs/mips-pic.s -o %t-pic.o
>  # RUN: llvm-mc -filetype=obj -triple=mips-unknown-linux %s -o %t-npic.o
> -# RUN: ld.lld %t-npic.o %t-pic.o -o %t.exe
> +# RUN: ld.lld %t-npic.o %t-pic.o %p/Inputs/mips-sto-pic.o -o %t.exe
>  # RUN: llvm-objdump -d %t.exe | FileCheck %s
>
>  # REQUIRES: mips
>
>  # CHECK:     Disassembly of section .text:
>  # CHECK-NEXT: __start:
> -# CHECK-NEXT:    20000:       0c 00 80 0a     jal     131112
> -#                                                     ^-- 0x20030 .pic.foo1a
> +# CHECK-NEXT:    20000:       0c 00 80 0e     jal     131128 <foo1b+0x4>
> +#                                                            ^-- .pic.foo1a
>  # CHECK-NEXT:    20004:       00 00 00 00     nop
> -# CHECK-NEXT:    20008:       0c 00 80 15     jal     131156
> -#                                                     ^-- 0x20060 .pic.foo2
> +# CHECK-NEXT:    20008:       0c 00 80 19     jal     131172 <foo2+0x4>
> +#                                                            ^-- .pic.foo2
>  # CHECK-NEXT:    2000c:       00 00 00 00     nop
> -# CHECK-NEXT:    20010:       0c 00 80 0e     jal     131128
> -#                                                     ^-- 0x20040 .pic.foo1b
> +# CHECK-NEXT:    20010:       0c 00 80 12     jal     131144 <foo1b+0x14>
> +#                                                            ^-- .pic.foo1b
>  # CHECK-NEXT:    20014:       00 00 00 00     nop
> -# CHECK-NEXT:    20018:       0c 00 80 15     jal     131156
> -#                                                     ^-- 0x20060 .pic.foo2
> +# CHECK-NEXT:    20018:       0c 00 80 19     jal     131172 <foo2+0x4>
> +#                                                            ^-- .pic.foo2
>  # CHECK-NEXT:    2001c:       00 00 00 00     nop
> +# CHECK-NEXT:    20020:       0c 00 80 28     jal     131232 <fnpic+0x10>
> +#                                                            ^-- .pic.fpic
> +# CHECK-NEXT:    20024:       00 00 00 00     nop
> +# CHECK-NEXT:    20028:       0c 00 80 24     jal     131216 <fnpic>
> +# CHECK-NEXT:    2002c:       00 00 00 00     nop
>  #
>  # CHECK:      foo1a:
> -# CHECK-NEXT:    20020:       00 00 00 00     nop
> +# CHECK-NEXT:    20030:       00 00 00 00     nop
>  #
>  # CHECK:      foo1b:
> -# CHECK-NEXT:    20024:       00 00 00 00     nop
> -#
> -# CHECK-NEXT:    20028:       3c 19 00 02     lui     $25, 2
> -# CHECK-NEXT:    2002c:       08 00 80 08     j       131104 <foo1a>
> -# CHECK-NEXT:    20030:       27 39 00 20     addiu   $25, $25, 32
>  # CHECK-NEXT:    20034:       00 00 00 00     nop
> +#
>  # CHECK-NEXT:    20038:       3c 19 00 02     lui     $25, 2
> -# CHECK-NEXT:    2003c:       08 00 80 09     j       131108 <foo1b>
> -# CHECK-NEXT:    20040:       27 39 00 24     addiu   $25, $25, 36
> +# CHECK-NEXT:    2003c:       08 00 80 0c     j       131120 <foo1a>
> +# CHECK-NEXT:    20040:       27 39 00 30     addiu   $25, $25, 48
>  # CHECK-NEXT:    20044:       00 00 00 00     nop
> -# CHECK-NEXT:    20048:       00 00 00 00     nop
> -# CHECK-NEXT:    2004c:       00 00 00 00     nop
> +# CHECK-NEXT:    20048:       3c 19 00 02     lui     $25, 2
> +# CHECK-NEXT:    2004c:       08 00 80 0d     j       131124 <foo1b>
> +# CHECK-NEXT:    20050:       27 39 00 34     addiu   $25, $25, 52
> +# CHECK-NEXT:    20054:       00 00 00 00     nop
> +# CHECK-NEXT:    20058:       00 00 00 00     nop
> +# CHECK-NEXT:    2005c:       00 00 00 00     nop
>  #
>  # CHECK:      foo2:
> -# CHECK-NEXT:    20050:       00 00 00 00     nop
> -#
> -# CHECK-NEXT:    20054:       3c 19 00 02     lui     $25, 2
> -# CHECK-NEXT:    20058:       08 00 80 14     j       131152 <foo2>
> -# CHECK-NEXT:    2005c:       27 39 00 50     addiu   $25, $25, 80
>  # CHECK-NEXT:    20060:       00 00 00 00     nop
> +#
> +# CHECK-NEXT:    20064:       3c 19 00 02     lui     $25, 2
> +# CHECK-NEXT:    20068:       08 00 80 18     j       131168 <foo2>
> +# CHECK-NEXT:    2006c:       27 39 00 60     addiu   $25, $25, 96
> +# CHECK-NEXT:    20070:       00 00 00 00     nop
> +# CHECK-NEXT:    20074:       00 00 00 00     nop
> +# CHECK-NEXT:    20078:       00 00 00 00     nop
> +# CHECK-NEXT:    2007c:       00 00 00 00     nop
> +#
> +# CHECK:      fpic:
> +# CHECK-NEXT:    20080:       00 00 00 00     nop
> +# CHECK-NEXT:    20084:       00 00 00 00     nop
> +# CHECK-NEXT:    20088:       00 00 00 00     nop
> +# CHECK-NEXT:    2008c:       00 00 00 00     nop
> +#
> +# CHECK:      fnpic:
> +# CHECK-NEXT:    20090:       00 00 00 00     nop
> +# CHECK-NEXT:    20094:       00 00 00 00     nop
> +# CHECK-NEXT:    20098:       00 00 00 00     nop
> +# CHECK-NEXT:    2009c:       00 00 00 00     nop
> +# CHECK-NEXT:    200a0:       3c 19 00 02     lui     $25, 2
> +# CHECK-NEXT:    200a4:       08 00 80 20     j       131200 <fpic>
> +# CHECK-NEXT:    200a8:       27 39 00 80     addiu   $25, $25, 128
>
>    .text
>    .globl __start
> @@ -56,3 +79,5 @@ __start:
>    jal foo2
>    jal foo1b
>    jal foo2
> +  jal fpic
> +  jal fnpic
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list