[PATCH] D18756: [Coverage] Avoid unnecessary copying of an array. NFC.

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 4 10:50:54 PDT 2016


vsk added a subscriber: vsk.
vsk added a comment.

I agree with dblaikie, the API could be a bit cleaner. Wdyt of this:

1. Have the SegmentBuilder constructor accept a `vector<CoverageSegment>&`; assert that it's empty.
2. Replace `Segments = SegmentBuilder().buildSegments(...)` with `SegmentBuilder(Segments).build(...)`.


http://reviews.llvm.org/D18756





More information about the llvm-commits mailing list