[PATCH] D18710: code hoisting using GVN

Sebastian Pop via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 4 08:40:22 PDT 2016


sebpop added inline comments.

================
Comment at: llvm/lib/Transforms/Scalar/GVN.cpp:2725
@@ +2724,3 @@
+HoistedScalarsThreshold("hoisted-scalars-threshold", cl::Hidden, cl::init(-1),
+                        cl::ZeroOrMore,
+    cl::desc("Max number of scalar instructions to hoist (default unlimited = -1)"));
----------------
mcrosier wrote:
> ZeroOrMore isn't generally used with cl::opt.
I copied the stmt from above: GVN.cpp line 76.  Do you have an alternative option I should be using?


Repository:
  rL LLVM

http://reviews.llvm.org/D18710





More information about the llvm-commits mailing list