[PATCH] D18729: [llvm-c] Improve IR Introspection: Add ValueKind

Amaury SECHET via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 3 15:47:20 PDT 2016


deadalnix added a comment.

If you guys think exposing this id is a good idea I won't oppose it. If I understand correctly, you want to avoid calling into LLVM too much in case the call itself is expensive ? It seems to me that the C API doesn't do a very good job at reducing the amount of calls, for instance various instructions cannot be built without multiple calls (among the worse offenders, landingpads). There is probably lower hanging fruits in that tree.

Anyway, as long as the enum value are stable, I'm won't oppose this. I just wanted to make sure you understands that goign froward with this means having an enum to maintain like forever.


http://reviews.llvm.org/D18729





More information about the llvm-commits mailing list