[PATCH] D18731: ELF: Create dynamic symbols for symbol aliases of copy relocations.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 2 14:50:11 PDT 2016


ruiu added inline comments.

================
Comment at: ELF/Writer.cpp:388
@@ -387,5 +387,3 @@
       if (Target->needsCopyRel<ELFT>(Type, *B)) {
-        B->NeedsCopyOrPltAddr = true;
-        Out<ELFT>::RelaDyn->addReloc(
-            {Target->CopyRel, DynamicReloc<ELFT>::Off_Bss, B});
+        addCopyRelSymbol(B);
         continue;
----------------
How is it guaranteed that this function is not called more than once for each shared symbol?


http://reviews.llvm.org/D18731





More information about the llvm-commits mailing list