[PATCH] D18647: [lit][googletest] Don't choke on non-executables

[Brian Gesiak via llvm-commits]

modocache added a comment.

I think this situation does signify a problem that should be remedied, but I think I disagree with the severity with which lit reports the problem. When running lit with `ShTest` on a directory containing no tests, for example, lit emits a warning but still exits successfully. Why should the `GoogleTest` format emit an error, as opposed to a warning?

My problem stems from the fact that I am running lit tests using a third-party project's `lit.cfg`. I'd rather not fork that project just to modify its test suffix setting, or to add an `lit_config.excludes`. Ideally I'd be able to use `lit.py --filter`, but that filter only applies to which tests are **run**, not which tests are discovered. And since `GoogleTest` fails during the discovery process here, `--filter` doesn't help.

My problem would also be solved by adding something like a top-level `lit.py --excludes` option, but this approach seemed like much less work. :)


http://reviews.llvm.org/D18647