[PATCH] D18704: [PGO] Use a helper function to find all indirect call-sites

Sean Silva via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 1 16:02:25 PDT 2016


silvas accepted this revision.
silvas added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.


================
Comment at: lib/Transforms/Instrumentation/IndirectCallSiteVisitor.h:36
@@ +35,3 @@
+// Helper function that finds all indirect call sites.
+inline static std::vector<Instruction *> findIndirectCallSites(Function &F) {
+  PGOIndirectCallSiteVisitor ICV;
----------------
Nit: I think we usually say `static inline`.


http://reviews.llvm.org/D18704





More information about the llvm-commits mailing list