[PATCH] D18092: Swift Calling Convention: add swifterror attribute

Manman Ren via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 1 12:51:12 PDT 2016


manmanren marked 4 inline comments as done.
manmanren added a comment.

Upload new patch to address review comments.

Cheers,
Manman


================
Comment at: docs/LangRef.rst:1070
@@ +1069,3 @@
+    pointer-sized alloca. At the call site, the actual argument that corresponds
+    to a ``swifterror`` parameter has to come from a ``swifterror`` alloca. A
+    ``swifterror`` value (either the parameter or the alloca) can only be loaded
----------------
@Mehdi
I am not sure about adding the calling convention part here. Any attribute that is related to a calling convention should be part of the ABI, right?
Let me know what you think about the new description :]

@John, do you have any comments on the alias part and this description in general?




http://reviews.llvm.org/D18092





More information about the llvm-commits mailing list