[PATCH] D18699: [ELF] - Teach linkerscript error handler to show full script line + column marker on error.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/LinkerScript.cpp:176
@@ -174,1 +175,3 @@
 
+std::pair<StringRef, size_t> ScriptParser::getLineColumn() {
+  const char *Begin = Input.data();
----------------
The string manipulation in this function seem a bit too complicated. StringRef provides a good set of utility functions to make this kind of stuff easy. Can you rewrite it with them?


http://reviews.llvm.org/D18699