[PATCH] D18691: [ELF] - Split Writer::assignAddresses(): extract code for initializing dummies sections

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a few nits.


================
Comment at: ELF/Writer.cpp:209
@@ -207,2 +208,3 @@
   Out<ELFT>::ProgramHeaders = &ProgramHeaders;
+  Out<ELFT>::ElfHeader->setSize(sizeof(Elf_Ehdr));
 
----------------
Please move this after

  OutputSectionBase<ELFT> ElfHeader("", 0, SHF_ALLOC);

================
Comment at: ELF/Writer.cpp:1334-1335
@@ -1331,1 +1333,4 @@
+
+  size_t PhdrSize = sizeof(Elf_Phdr) * Phdrs.size();
+  Out<ELFT>::ProgramHeaders->setSize(PhdrSize);
 }
----------------
  Out<ELFT>::ProgramHeaders->setSize(sizeof(Elf_Phdr) * Phdrs.size());


http://reviews.llvm.org/D18691