[PATCH] D17201: [SCEV] Introduce a guarded backedge taken count and use it in LAA and LV

silviu.baranga@arm.com via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 1 09:05:33 PDT 2016


sbaranga added inline comments.

================
Comment at: lib/Analysis/ScalarEvolutionExpander.cpp:2007-2009
@@ -2006,3 +2006,5 @@
 
-  const SCEV *ExitCount = SE.getBackedgeTakenCount(AR->getLoop());
+  SCEVUnionPredicate Pred;
+  const SCEV *ExitCount =
+      SE.getPredicatedBackedgeTakenCount(AR->getLoop(), Pred);
   const SCEV *Step = AR->getStepRecurrence(SE);
----------------
sbaranga wrote:
> I've re-audited the
> 
> Please see the updated definition of the SCEVWrapPredicate which should make this point clear.
> 
> Regarding the code restructuring: I don't see a good solution for this either.
I meant to write that I've re-audited the places where we were using the predicates, and I think everything is ok.


http://reviews.llvm.org/D17201





More information about the llvm-commits mailing list