[PATCH] D18092: Swift Calling Convention: add swifterror attribute

John McCall via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 31 20:45:16 PDT 2016


rjmccall added inline comments.

================
Comment at: lib/IR/Verifier.cpp:2493
@@ +2492,3 @@
+      Value *SwiftErrorArg = CS.getArgument(i);
+      if (auto AI = dyn_cast<AllocaInst>(SwiftErrorArg->stripInBoundsOffsets()))
+        Assert(AI->isSwiftError(),
----------------
Should this be asserting that SwiftErrorArg is an alloca?


http://reviews.llvm.org/D18092





More information about the llvm-commits mailing list