[PATCH] D18429: Add lowering support for llvm.experimental.deoptimize
    Sanjoy Das via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Mar 31 19:31:00 PDT 2016
    
    
  
Justin Lebar wrote:
 > Hi, I think this may be broken.
 >
 > In particular, I tried to land http://reviews.llvm.org/rL265092,
 > which turns on an assertion, but had to back it out because it asserts
 > on the test added here.  (The assertion is currently only run with
 > -debug, which is doubly bad, because now your code can break for
 > unrelated reasons while you're trying to debug it!)
Looks like webkit_jscc does not work with anything but an i64 return
type.  The following crashes llc, for instance:
target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-apple-macosx10.11.0"
declare webkit_jscc i32 @foo()
define i32 @caller() {
entry:
   %v = call webkit_jscc i32 @foo()
   ret i32 %v
}
CC'ing Andy and Juergen, since they might know.  For now I'll switch
the test to return i64 and turn on the assertion.
 > Would you mind having a look?  Bonus points if you reland
 > http://reviews.llvm.org/rL265092 after fixing the issue.
-- Sanjoy
    
    
More information about the llvm-commits
mailing list