[PATCH] D18634: Don't IPO over functions that can be de-refined

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 31 18:37:43 PDT 2016


sanjoy added inline comments.

================
Comment at: include/llvm/IR/GlobalValue.h:296-298
@@ +295,5 @@
+
+    default:
+      return false;
+    }
+
----------------
chandlerc wrote:
> This seems wrong. If the function may be overridden, then it necessarily may be overridden by a function which is less refined?
> 
> I actually think having these form nicely nested sets is better.
> This seems wrong. If the function may be overridden, then it necessarily may be overridden by a function which is less refined?
>
> I actually think having these form nicely nested sets is better.

I had that form initially (and I prefer that more).  I thought this one would be less confusing, but looks like it isn't.  Switched to nested sets.


http://reviews.llvm.org/D18634





More information about the llvm-commits mailing list