[PATCH] D17792: Initialize much of AssemblyWriter lazily.

[Tim Shen via llvm-commits]

timshen added a comment.

I don't have more comments. Should I just stamp this patch?


================
Comment at: lib/IR/AsmWriter.cpp:461
@@ +460,3 @@
+  auto NextToUse = LazyNamedTypes->begin();
+  for (auto I = LazyNamedTypes->begin(), E = LazyNamedTypes->end(); I != E;
+       ++I) {
----------------
Optional:

  LazyNamedTypes.erase(
    std::remove_if(LazyNamedTypes.begin(), LazyNamedTypes.end(),
      [&](...) { ... }),
    LazyNamedTypes.end());

?

I don't know if you like this half-functional style or pure imperative style.


http://reviews.llvm.org/D17792