[PATCH] D18586: Allow DeadStoreElimination to track combinations of partial later wrties

Erik Eckstein via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 31 11:13:04 PDT 2016


eeckstein added inline comments.

================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:457
@@ +456,3 @@
+    auto ILI = IM.find(LaterIntStart);
+    if (ILI != IM.end() && ILI.start() < LaterIntEnd) {
+      // This existing interval ends in the middle of
----------------
Shouldn't this be
 if (ILI != IM.end() && ILI.stop() < LaterIntEnd) {

If yes, then what if the existing interval completely covers the Later-interval? I.e. if ILI.stop() >= LaterIntEnd


http://reviews.llvm.org/D18586





More information about the llvm-commits mailing list