[PATCH] D18440: Don't use potentially invalidated iterator
David Blaikie via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 31 08:06:42 PDT 2016
LGTM, thanks!
(drop the const from const auto - we don't usually constify value types
defensively like that)
Also - what type is 'n'? Something simple/cheap? Or should it be referenced
by (const) ref instead of by value?
On Thu, Mar 31, 2016 at 2:49 AM, Stephan Bergmann via llvm-commits <
llvm-commits at lists.llvm.org> wrote:
> sberg added a comment.
>
> friendly ping
>
> (I have commit access now, so all it would need is a "lgtm" :)
>
>
> http://reviews.llvm.org/D18440
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160331/e37407cb/attachment.html>
More information about the llvm-commits
mailing list