[PATCH] D18402: [AArch64] Better errors for out-of-range fixups

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 31 03:00:55 PDT 2016


rengolin added a reviewer: jmolloy.
rengolin added a comment.

Sorry, this fell out of my radar. How can you guarantee the fixup and the value are the exact same? What if some process (even if later on), does change it?

I think if the ARM one works in the same way, then both are wrong...

I'll defer to Tim and James to accept this, as I'm not comfortable with the idea.

Reporting an error is better than crashing, but crashing is better than silent codegen errors.

cheers,
--renato


Repository:
  rL LLVM

http://reviews.llvm.org/D18402





More information about the llvm-commits mailing list