[lld] r264983 - Revert "Remove useless unreachable. Switch coverage already gives us this. NFC"

Pete Cooper via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 30 18:23:23 PDT 2016


Author: pete
Date: Wed Mar 30 20:23:23 2016
New Revision: 264983

URL: http://llvm.org/viewvc/llvm-project?rev=264983&view=rev
Log:
Revert "Remove useless unreachable.  Switch coverage already gives us this.  NFC"

This reverts commit r264945.

The commit only removed an unreachable in a method with a covered switch, but
GCC is likely to warn on this, and the coding standards recommend just leaving
in the unreachable.

Modified:
    lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileFromAtoms.cpp

Modified: lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileFromAtoms.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileFromAtoms.cpp?rev=264983&r1=264982&r2=264983&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileFromAtoms.cpp (original)
+++ lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileFromAtoms.cpp Wed Mar 30 20:23:23 2016
@@ -865,6 +865,7 @@ llvm::Error Util::getSymbolTableRegion(c
     }
     break;
   }
+  llvm_unreachable("atom->scope() unknown enum value");
 }
 
 llvm::Error Util::addSymbols(const lld::File &atomFile,




More information about the llvm-commits mailing list