[PATCH] D18097: [Power9] basic support for Power 9 direct move instructions

amehsan via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 30 17:38:13 PDT 2016


amehsan added inline comments.

================
Comment at: lib/Target/PowerPC/PPC.td:141
@@ +140,3 @@
+                   "Enable Power9 direct move instructions",
+                   [FeatureDirectMove]>;
+
----------------
kbarton wrote:
> Please make sure this also requires the ISA3_0 feature that is defined in [[ http://reviews.llvm.org/D18032 | D18032 ]]
I believe we don't want P9DirectMove to imply ISA3_0, but as we discussed separately, I will totally remove this feature. I will guard the instructions with 

let Predicate = [ISA3_0, HasDirectMove]





http://reviews.llvm.org/D18097





More information about the llvm-commits mailing list