[PATCH] D18579: SetVector: Add front, pop_front and resize operations
Matthias Braun via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 30 15:31:28 PDT 2016
MatzeB added a comment.
In http://reviews.llvm.org/D18579#386552, @dblaikie wrote:
> Test cases?
> Got use cases in mind? (specific new/incoming patches to LLVM projects that
> will use this functionality)
See http://reviews.llvm.org/D18427
> & 'resize' seems like the wrong name for a set or map operation - perhaps
> "reserve"? (I think there was a recent change for this rename in DenseMap,
> right?)
It is still called resize() in DenseSet, SmallPtrSet and BitVector so I'd like to keep that name for consistency. Of course someone else can rename them all to reserve() in the future.
Repository:
rL LLVM
http://reviews.llvm.org/D18579
More information about the llvm-commits
mailing list