[PATCH] D18623: [PGO] refactor PGOFuncName meta data code to be used in clang

[David Li via llvm-commits]

davidxl added inline comments.

================
Comment at: include/llvm/ProfileData/InstrProf.h:250
@@ -247,1 +249,3 @@
 
+inline StringRef PGOFuncNameMetaData(){
+  return "PGOFuncName";
----------------
clang-format it.

-->getPGOFuncNameMetaDataKind()

================
Comment at: include/llvm/ProfileData/InstrProf.h:262
@@ +261,3 @@
+/// only. Return true if the meta data is written out, and false if not.
+inline bool createPGOFuncNameMetaData(Function &F) {
+  const std::string &FuncName = getPGOFuncName(F);
----------------
Not suitable for being an 'inline' function. Put the def in InstrProf.cpp.


http://reviews.llvm.org/D18623