[PATCH] D16325: Add support for computing SHA1 in LLVM
Mehdi AMINI via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 30 12:05:50 PDT 2016
joker.eph marked an inline comment as done.
joker.eph added a comment.
Thanks Rui for the comments.
================
Comment at: include/llvm/Support/SHA1.h:34
@@ +33,3 @@
+ /// Digest more data.
+ void update(const char *data, size_t len);
+
----------------
ruiu wrote:
> Why don't you pass ArrayRef<uint8_t>?
Just mimic the API I was wrapping. That's a good point, updated!
================
Comment at: include/llvm/Support/SHA1.h:41-45
@@ +40,7 @@
+
+ /// Return a reference to the current SHA1 for the digested data since the
+ /// last call to init(). This is suitable for getting the SHA1 at any time
+ /// without invalidating the internal state so that more calls can be made
+ /// into update.
+ StringRef result();
+
----------------
ruiu wrote:
> It is not clear in this comment whether this function returns a hex string or raw bytes.
Updated!
http://reviews.llvm.org/D16325
More information about the llvm-commits
mailing list