[PATCH] D18546: Prevent X86IselLowering from merging volatile loads

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 30 10:38:53 PDT 2016


spatel added a comment.

In http://reviews.llvm.org/D18546#387143, @jyknight wrote:

> That makes sense to me. The only other caller in-tree of this function already checks isVolatile, anyways.


Thanks for checking that. Note that the PPC backend has this:

  // Like SelectionDAG::isConsecutiveLoad, but also works for stores, and does
  // not enforce equality of the chain operands.
  static bool isConsecutiveLS(SDNode *N, LSBaseSDNode *Base,

...I didn't look closely, but it might have related problems.

Also, independent of volatile but maybe affected by the other patches-in-progress:
https://llvm.org/bugs/show_bug.cgi?id=10114


http://reviews.llvm.org/D18546





More information about the llvm-commits mailing list