[PATCH] D18333: [ELF/AArch64] Add aarch64 TLS IE to LE relax for local symbol test

Adhemerval Zanella via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 30 10:17:03 PDT 2016


zatrazz added inline comments.

================
Comment at: test/ELF/aarch64-tls-iele.s:17
@@ +16,3 @@
+# CHECK-NEXT: 11004:  80 02 80 f2   movk   x0, #0x14
+# CHECK-NEXT: 11008:  00 00 a0 d2   movz   x0, #0, lsl #16
+# CHECK-NEXT: 1100c:  00 02 80 f2   movk   x0, #0x10
----------------
rengolin wrote:
> I think there should be an "ldr" in between these two pairs, in which case the test would fail?
> 
> Either adding a:
>     CHECK-NEXT: ldr
> in between the two pairs, or changing the third line to:
>     CHECK: 11008:  00 00 a0 d2   movz   x0, #0, lsl #16
> 
> should work.
There is no need of 'ldr' because the idea of TLS IE to LE isto exactly remove the ldr and changing it to movz.


Repository:
  rL LLVM

http://reviews.llvm.org/D18333





More information about the llvm-commits mailing list