[PATCH] D18213: Add a module Hash in the bitcode and the combined index.

[Teresa Johnson via llvm-commits]

tejohnson added inline comments.

================
Comment at: test/Bitcode/module_hash.ll:7
@@ +6,3 @@
+
+; Check that the hash matches in the combined index
+
----------------
joker.eph wrote:
> Came up with a different approach!
> 
> 1) llvm-bcanalyzer will re-hash and check for mismatch
> 2) using a temporary file to collect the hash, I check that whatever is in the module is correctly propagated into the combined index.
Weird, I still don't see the test when I go to http://reviews.llvm.org/D18213, only when I click on this comment which opens up http://reviews.llvm.org/D18213?id=51672#inline-155131.

In any case, this sounds good. The version of the test I am seeing doesn't implement it yet (assume that is WIP).

================
Comment at: tools/llvm-bcanalyzer/llvm-bcanalyzer.cpp:540
@@ -537,3 +539,3 @@
       outs() << "/>";
 
       if (Abbv) {
----------------
Ok, got it, checking both does make sense.


http://reviews.llvm.org/D18213