[lld] r264863 - Fix handling of addends on i386.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 30 07:22:05 PDT 2016


On 30 March 2016 at 09:13, Simon Atanasyan <simon at atanasyan.com> wrote:
> Are you going to implement MipsTargetInfo::getImplicitAddend. I can do
> that by myself.

Just did :-)

> BTW what do you think about moving the `TargetInfo::getImplicitAddend`
> to the getAddend() function. In that case interface of getAddend
> becomes more complicated but we can abstract from REL/RELA relocation
> record format and get correct addend everywhere we need it.

I will do something similar.

My idea is to use the first pass over the relocations (scanRelocs) to
record what it found about them (the final symbol, if got is being
used, the addend, etc) and then relocation application can use that.

Cheers,
Rafael


More information about the llvm-commits mailing list