[PATCH] D18097: [Power9] basic support for Power 9 direct move instructions

[Kit Barton via llvm-commits]

kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.

Some minor formatting changes, add the ISA3_0 feature, and change the input register class on one of the instructions.
With these changes, this LGTM.


================
Comment at: lib/Target/PowerPC/PPC.td:137
@@ -136,1 +136,3 @@
                    [FeatureVSX]>;
+
+def FeatureP9DirectMove :
----------------
Please remove blank lines to remain consistent with other feature definitions.

================
Comment at: lib/Target/PowerPC/PPC.td:141
@@ +140,3 @@
+                   "Enable Power9 direct move instructions",
+                   [FeatureDirectMove]>;
+
----------------
Please make sure this also requires the ISA3_0 feature that is defined in [[ http://reviews.llvm.org/D18032 | D18032 ]]

================
Comment at: lib/Target/PowerPC/PPC.td:142
@@ -137,1 +141,3 @@
+                   [FeatureDirectMove]>;
+
 def FeaturePartwordAtomic : SubtargetFeature<"partword-atomics",
----------------
Remove blank line

================
Comment at: lib/Target/PowerPC/PPCInstrVSX.td:1243
@@ +1242,3 @@
+  // P9 direct move instructions
+  def MTVSRWS: XX1_RS6_RD5_XO<31, 403, (outs vsrc:$XT), (ins gprc:$rA),
+                              "mtvsrws $XT, $rA", IIC_VecGeneral,
----------------
Please change this to g8rc:$rA


http://reviews.llvm.org/D18097