[PATCH] D18576: Initial implementation of optimization bisect

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 29 18:08:45 PDT 2016


joker.eph added inline comments.

================
Comment at: lib/IR/OptBisect.cpp:118
@@ +117,3 @@
+    "Lower 'expect' Intrinsics"
+};
+
----------------
Ew, that's pretty terrible to have this inlined here. But I agree it is not easy to decouple...
Maybe having a new (optional?) API on the Passes themselves may be cleaner.
Something like `bool isRequiredForCorrectness()`?


Repository:
  rL LLVM

http://reviews.llvm.org/D18576





More information about the llvm-commits mailing list