[PATCH] D18529: Add a dump method to MachineFunctionProperties for better error messages
Quentin Colombet via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 29 10:26:34 PDT 2016
qcolombet added inline comments.
================
Comment at: include/llvm/CodeGen/MachineFunction.h:146
@@ -145,1 +145,3 @@
+ void dump(raw_ostream &ROS) const;
+
----------------
Short story, rename dump -> print.
The convention is to have dump to be available only in debug build, but more importantly to have it to print on dbgs().
What we want here is a print method.
================
Comment at: lib/CodeGen/MachineFunction.cpp:396
@@ +395,3 @@
+ OS << "Properties: <";
+ getProperties().dump(OS);
+ OS << "> : ";
----------------
print calls print, not dump.
http://reviews.llvm.org/D18529
More information about the llvm-commits
mailing list