[PATCH] D18321: Add support for no-jump-tables

Nirav Dave via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 29 09:56:10 PDT 2016


niravd added inline comments.

================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7964
@@ +7963,3 @@
+  if (fn->hasFnAttribute("no-jump-tables") &&
+      fn->getFnAttribute("no-jump-tables").getValueAsString() == "true")
+    return false;
----------------
hans wrote:
> Would just
> 
>   if (Fn->getFnAttribute("no-jump-tables").getValueAsString() == "true")
> 
> work?
It does. There are a few more instances of this pattern in the codebase. I'll submit those separately.


http://reviews.llvm.org/D18321





More information about the llvm-commits mailing list