[PATCH] D18453: AMDGPU/SI: Improve MachineSchedModel definition

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 29 07:09:20 PDT 2016


tstellarAMD added inline comments.

================
Comment at: lib/Target/AMDGPU/SISchedule.td:43
@@ +42,3 @@
+class SISchedMachineModel : SchedMachineModel {
+	let CompleteModel = 0;
+	let IssueWidth = 1;
----------------
arsenm wrote:
> Is there much more to do to complete the model?
We need to add scheduler information for the generic COPY instruction.  Maybe a few other things too.

================
Comment at: lib/Target/AMDGPU/SISchedule.td:50
@@ -51,2 +49,3 @@
 
 // XXX: Are the resource counts correct?
+def HWBranch : ProcResource<1> {
----------------
arsenm wrote:
> Is this comment still needed?
Yes, I'm still not sure about this.


http://reviews.llvm.org/D18453





More information about the llvm-commits mailing list