[PATCH] D18545: [ELF] - Better diagnostics for linker script errors

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 29 06:23:54 PDT 2016


grimar added a comment.

In http://reviews.llvm.org/D18545#385425, @emaste wrote:

> If you do display the full line and keep track of the column too then the "but got" can be removed from the message.
>
>   .keep + { *(.keep) }
>         ^
>   test.script:3:7: error: ':' expected
>
>
> Having at least the line number for now though would be a good help while testing the in-progress linker script support.


Yes, that would look better IMO. This patch can put a start for implementation of such messages.


http://reviews.llvm.org/D18545





More information about the llvm-commits mailing list