[LNT] r264719 - [ui] Pass the run ID being compared to into the main macro

James Molloy via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 29 04:07:51 PDT 2016


Author: jamesm
Date: Tue Mar 29 06:07:50 2016
New Revision: 264719

URL: http://llvm.org/viewvc/llvm-project?rev=264719&view=rev
Log:
[ui] Pass the run ID being compared to into the main macro

I was using "compare_to" to get the ID of the run being compared to, but actually this isn't passed in and could be previoud or baseline at this point. Pass it in so we can form profile links correctly.

Modified:
    lnt/trunk/lnt/server/ui/templates/reporting/runs.html

Modified: lnt/trunk/lnt/server/ui/templates/reporting/runs.html
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/ui/templates/reporting/runs.html?rev=264719&r1=264718&r2=264719&view=diff
==============================================================================
--- lnt/trunk/lnt/server/ui/templates/reporting/runs.html (original)
+++ lnt/trunk/lnt/server/ui/templates/reporting/runs.html Tue Mar 29 06:07:50 2016
@@ -6,7 +6,7 @@
 #}
 {%
   macro add_report_changes_detail_for_field_and_bucket(
-    field, show_perf, run_url, field_index, field_display_name, bucket_name, bucket, test_names,
+    compare_to, field, show_perf, run_url, field_index, field_display_name, bucket_name, bucket, test_names,
     metric_name, metric_field_suffix, secondary_field_suffix, secondary_info, styles, classes
   )
 %}
@@ -166,7 +166,7 @@
   {% set field_display_name = {"compile_time":"Compile Time",
                                "execution_time":"Execution Time"}.get(field.name, field.name) %}
   {{
-    add_report_changes_detail_for_field_and_bucket(field, show_perf, run_url, field_index, field_display_name,
+    add_report_changes_detail_for_field_and_bucket(compare_to, field, show_perf, run_url, field_index, field_display_name,
                                                    bucket_name, sorted_bucket, test_names,
                                                    'Previous', '', ' (B)', run_to_baseline_info, styles, classes)
   }}
@@ -179,7 +179,7 @@
   {% set field_display_name = {"compile_time":"Compile Time",
                                "execution_time":"Execution Time"}.get(field.name, field.name) %}
   {{
-    add_report_changes_detail_for_field_and_bucket(field, show_perf, run_url, field_index, field_display_name,
+    add_report_changes_detail_for_field_and_bucket(baseline, field, show_perf, run_url, field_index, field_display_name,
                                                    bucket_name, sorted_bucket, test_names,
                                                    'Baseline', '(B)', '', run_to_run_info, styles, classes)
   }}




More information about the llvm-commits mailing list