[PATCH] D18349: [ELF][MIPS] Reduce number of redundant entries in the local part of MIPS GOT

[Simon Atanasyan via llvm-commits]

atanasyan updated the summary for this revision.
atanasyan updated this revision to Diff 51883.
atanasyan added a comment.

- Fixed the comment describes how we count the number of required GOT entries.
- Removed changes from Writer.cpp. I reviewed this code once again and realized that the changes can be rolled back. The only section (except .dynamic, .got.plt etc) which can modify its sh_size in the finalize method is the MergeOutputSection. But such sections always go before the .got section in the OutputSections container because we support only read-only merge sections and read-only sections go before writable ones. So it is does not necessary to postpone finalizing of the .got section. It would be nice to have an assert to check that fact but I cannot find how to do that without significant modification of the code.


Repository:
  rL LLVM

http://reviews.llvm.org/D18349

Files:
  ELF/OutputSections.cpp
  ELF/OutputSections.h
  test/ELF/mips-got-redundant.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D18349.51883.patch
Type: text/x-patch
Size: 4728 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160329/d4243996/attachment.bin>