[PATCH] D18357: [LTO] Include in .symtab/.dynsym symbols introduced by optimizations

[Rafael Espíndola via llvm-commits]

Lgtm.

Thanks
Rafael
On Mar 28, 2016 6:44 PM, "Davide Italiano" <dccitaliano at gmail.com> wrote:

> davide updated this revision to Diff 51847.
> davide added a comment.
>
> Rafael's comments.
>
>
> http://reviews.llvm.org/D18357
>
> Files:
>   ELF/SymbolTable.cpp
>   ELF/Symbols.h
>   test/ELF/lto/Inputs/shared.s
>   test/ELF/lto/undefined-puts.ll
>
> Index: test/ELF/lto/undefined-puts.ll
> ===================================================================
> --- /dev/null
> +++ test/ELF/lto/undefined-puts.ll
> @@ -0,0 +1,28 @@
> +; REQUIRES: x86
> +; RUN: llvm-mc %p/Inputs/shared.s -o %t1.o -filetype=obj
> -triple=x86_64-unknown-linux
> +; RUN: ld.lld %t1.o -o %t1.so -shared
> +; RUN: llvm-as %s -o %t2.o
> +; RUN: ld.lld %t1.so %t2.o -m elf_x86_64 -o %t
> +; RUN: llvm-readobj -dyn-symbols -dyn-relocations %t | FileCheck %s
> +
> +target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
> +target triple = "x86_64-unknown-linux-gnu"
> +
> + at .str = private unnamed_addr constant [6 x i8] c"blah\0A\00", align 1
> +
> +define i32 @_start() {
> +  %str = call i32 (i8*, ...) @printf(i8* getelementptr inbounds ([6 x
> i8], [6 x i8]* @.str, i32 0, i32 0))
> +  ret i32 0
> +}
> +
> +declare i32 @printf(i8*, ...)
> +
> +; Check that puts symbol is present in the dynamic symbol table and
> +; there's a relocation for it.
> +; CHECK: Dynamic Relocations {
> +; CHECK-NEXT:  0x11007 R_X86_64_PC32 puts 0xFFFFFFFFFFFFFFFC
> +; CHECK-NEXT: }
> +
> +; CHECK: DynamicSymbols [
> +; CHECK: Symbol {
> +; CHECK:    Name: puts@
> Index: test/ELF/lto/Inputs/shared.s
> ===================================================================
> --- /dev/null
> +++ test/ELF/lto/Inputs/shared.s
> @@ -0,0 +1,5 @@
> +.globl  printf
> +printf:
> +
> +.globl  puts
> +puts:
> Index: ELF/Symbols.h
> ===================================================================
> --- ELF/Symbols.h
> +++ ELF/Symbols.h
> @@ -89,6 +89,8 @@
>    bool isInGot() const { return GotIndex != -1U; }
>    bool isInPlt() const { return PltIndex != -1U; }
>
> +  void setUsedInRegularObj() { IsUsedInRegularObj = true; }
> +
>    template <class ELFT>
>    typename ELFT::uint getVA(typename ELFT::uint Addend = 0) const;
>
> @@ -319,7 +321,6 @@
>    std::unique_ptr<InputFile> getMember();
>
>    void setWeak() { IsWeak = true; }
> -  void setUsedInRegularObj() { IsUsedInRegularObj = true; }
>
>  private:
>    ArchiveFile *File;
> Index: ELF/SymbolTable.cpp
> ===================================================================
> --- ELF/SymbolTable.cpp
> +++ ELF/SymbolTable.cpp
> @@ -108,6 +108,7 @@
>    Obj->parse(DummyGroups);
>    for (SymbolBody *Body : Obj->getNonLocalSymbols()) {
>      Symbol *Sym = insert(Body);
> +    Sym->Body->setUsedInRegularObj();
>      if (!Sym->Body->isUndefined() && Body->isUndefined())
>        continue;
>      Sym->Body = Body;
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160328/341a0fcb/attachment.html>